search

OceanParcels / virtualship

Authentic tool and teaching material about sea-based research
https://virtualship.oceanparcels.org/
MIT License
5 stars 1 forks source link

CTD noise and CNV output format #50

Closed surgura closed 3 months ago

surgura commented 3 months ago

30 for CTD only

surgura commented 3 months ago

Sorry for the one million files in the test zarr. I could also generate that on the fly instead of saving? maybe that's beter, not sure

erikvansebille commented 3 months ago

Yes, I think that creating the zarr on the fly is better; as it will then also check whether zarr files are created as expected. Alternative is to put .zarr files in the gitignore?

Oh, and should the CNV is the title of this PR not be CSV?

surgura commented 3 months ago

Yes, I think that creating the zarr on the fly is better; as it will then also check whether zarr files are created as expected. Alternative is to put .zarr files in the gitignore?

Oh, and should the CNV is the title of this PR not be CSV?

The file format is CNV, a file format created by Seabird(the microcat brand) The zarr file is in the test directory and used for the test. There already is a test for the creation of the zarr so that is not needed. I can either create it before running the rest by using the ctd function, but I think it might be better to replace this huge file with a very short zarr. That way a we have a fast test without having too much data on git

erikvansebille commented 3 months ago

By changing the chunks parameter in the ParticleFile object creation, you can also limit the number of files (=chunks) generated. See the note at https://docs.oceanparcels.org/en/latest/examples/tutorial_parcels_structure.html#4.-Execution-and-output

surgura commented 3 months ago

By changing the chunks parameter in the ParticleFile object creation, you can also limit the number of files (=chunks) generated. See the note at https://docs.oceanparcels.org/en/latest/examples/tutorial_parcels_structure.html#4.-Execution-and-output

Ok makes sense I will keep that in mind. I have create a very small one now and I think this should be fine as test input?