OceanParcels / virtualship

Authentic tool and teaching material about sea-based research
https://virtualship.oceanparcels.org/
MIT License
5 stars 1 forks source link

Add `init` command #72

Closed VeckoTheGecko closed 1 month ago

VeckoTheGecko commented 1 month ago

Fixes #67

Changes:


Good to know

virtualship now comes with a virtualship.static folder which is used to store static files (e.g., example configuration .yml files). For data files (which are larger, and aren't as core to the functionality of virtualship) shouldn't be put here but instead should be downloaded on demand.

virtualship.utils contains a bunch of utilities for virtualship, including convenience functions for reading these static files

VeckoTheGecko commented 1 month ago

Static files aren't being packaged properly despite working locally. Removing the --no-build-isolation flag would fix it, but I'm not 100% sure if that's the right fix. Waiting on reponse in https://github.com/pypa/setuptools/discussions/4694

VeckoTheGecko commented 1 month ago

Decided to just remove the flag --no-build-isolation

codecov-commenter commented 1 month ago

Codecov Report

Attention: Patch coverage is 96.77419% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@05d4fbd). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/virtualship/expedition/do_expedition.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #72 +/- ## ======================================= Coverage ? 83.06% ======================================= Files ? 27 Lines ? 856 Branches ? 0 ======================================= Hits ? 711 Misses ? 145 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.