Closed VeckoTheGecko closed 1 month ago
Static files aren't being packaged properly despite working locally. Removing the --no-build-isolation
flag would fix it, but I'm not 100% sure if that's the right fix. Waiting on reponse in https://github.com/pypa/setuptools/discussions/4694
Decided to just remove the flag --no-build-isolation
Attention: Patch coverage is 96.77419%
with 1 line
in your changes missing coverage. Please review.
Please upload report for BASE (
main@05d4fbd
). Learn more about missing BASE report.
Files with missing lines | Patch % | Lines |
---|---|---|
src/virtualship/expedition/do_expedition.py | 80.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Fixes #67
Changes:
virtualship init
commandmeta.yml
(managed by the feedstock)Good to know
virtualship
now comes with avirtualship.static
folder which is used to store static files (e.g., example configuration.yml
files). For data files (which are larger, and aren't as core to the functionality of virtualship) shouldn't be put here but instead should be downloaded on demand.virtualship.utils
contains a bunch of utilities forvirtualship
, including convenience functions for reading these static files