Ocelot-Social-Community / Ocelot-Social

Free and open-source social network for active citizenship.
https://ocelot.social
Other
94 stars 37 forks source link

🔧 [Refactor] E-Mail Templates To Be In A Single Language And Not Multi Language #4786

Open Tirokk opened 2 years ago

Tirokk commented 2 years ago

🔧 Refactor

E-Mail templates to be in a single language and not multi language. https://github.com/Ocelot-Social-Community/Ocelot-Social/tree/master/backend/src/middleware/helpers/email/templates

Have a look at the notifications template. See: https://github.com/Ocelot-Social-Community/Ocelot-Social/blob/master/backend/src/middleware/helpers/email/templates/en/notification.html And: https://github.com/Ocelot-Social-Community/Ocelot-Social/blob/master/backend/src/middleware/helpers/email/templates/de/notification.html

Todo

ibonkonesa commented 2 years ago

Hi! Still open?

Tirokk commented 2 years ago

Hey @ibonkonesa ,

yes it's still open. You can take over. That’s great! 🤗 I assigned you to this issue.

I cared for your invitation to our community as volunteer via an e-mail invitation you can accept.

Our conversation runs over our discord server: https://discord.gg/AJSX9DCSUA There we have usually from Monday to Thursday a Daily Standup at UTC 09:30 am (CEST 11:30 am) in the Office Cube.

Please don’t compare from your fork to this repository, in case, because the publish GitHub Action will fail, because of permission problems with the credentials. Just push your branch directly to our repo and compare to the master. If you accept the invitation then you’ll have the right todo so. 😉

Tirokk commented 2 years ago

The ”think about“ in the discription should be moved to a question issue and not be part of this issue here anymore. So just split english and german up if you like to.

I moved it to here #5461 .

ibonkonesa commented 2 years ago

What's exactly the point??

Tirokk commented 2 years ago

What's exactly the point??

* Remove the Deutsch language mailing and ALL emails have to been sent in English
  or

* If user uses Deutsch language, send in Deutsch. Anyelse languages will be sent in English

We have only one e-mail separated in the two languages Deutsch and English:

All the other e-mails in folder https://github.com/Ocelot-Social-Community/Ocelot-Social/blob/master/backend/src/middleware/helpers/email/templates are in Deutsch and English.

We like to separate them and put them in the two folders templates/de/ and templates/en/ like the notification e-mail is. English is always the default language if the user language is not supported.

Just in case you are able and like to translate them just go ahead.

For sure you can just pickup one e-mail as a start and do as many you like to.