search

Octal450 / J-Runner-with-Extras

Source code to the J-Runner with Extras executable. Requires the proper support files, package can be found in README
https://www.realmodscene.com/index.php?/topic/10565-j-runner-with-extras-17559-built-in-timings-bugfixes-and-new-features/
MIT License
248 stars 33 forks source link

Bug - JRunner UI crashes #56

Closed ElecTriX666 closed 3 months ago

ElecTriX666 commented 4 months ago

Describe the bug UI crashes when trying to create XeBuild with selected drives patches and "other patches".

If skipping drive patches and other patches build works as expected.

To Reproduce Steps to reproduce the behaviour:

  1. Load source file (nand.bin)
  2. Select kernel 17559, Glitch2, RGH3 25mhz
  3. Go to tab "Patches" and select "Both XL", "UsbdSec" and "Key fix"
  4. UI takes a second then force closes

Expected behaviour A build is done?

Screenshots image image

System (please complete the following information):

Additional context Error.log;

System.IO.IOException: Det går inte att skapa en fil som redan finns. vid System.IO.Error.WinIOError(Int32 errorCode, String maybeFullPath) vid System.IO.Error.WinIOError() vid System.IO.File.InternalMove(String sourceFileName, String destFileName, Boolean checkHost) vid JRunner.Classes.xebuild.copyXLBoth() vid JRunner.Classes.xebuild.createxebuild(Boolean custom) vid JRunner.Panels.XeBuildPanel.createxebuild_v2(Boolean custom, PrivateN nand, Boolean fullDataClean) vid JRunner.MainForm.b__186_0() vid System.Threading.ThreadHelper.ThreadStart_Context(Object state) vid System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) vid System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx) vid System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state) vid System.Threading.ThreadHelper.ThreadStart()

Octal450 commented 4 months ago

This error it sounds like Windows Defender sandboxing. Please add exception to the app. As such I cannot reproduce it.

I will see if I can handle that gracefully and warn the user.

Kind Regards, Josh

ElecTriX666 commented 4 months ago

This error it sounds like Windows Defender sandboxing. Please add exception to the app. As such I cannot reproduce it.

I will see if I can handle that gracefully and warn the user.

Kind Regards, Josh

Hi,

Sorry but Defender is not activated and no other antivirus is installed.

System.IO.IOException: Det går inte att skapa en fil som redan finns. translation System.IO.IOException: Can not create a file that already exists.

This error shows even with a clean unpacked Jrunner. With no created folders

ElecTriX666 commented 3 months ago

@Octal450

Octal450 commented 3 months ago

Reproduced.

Working on a fix.

Kind Regards, Josh

Octal450 commented 3 months ago

It occurs if a build fails and then you try to rebuild. Files are left in an invalid state. If you use restore files option from hamburger menu it'll fix it.

Octal450 commented 3 months ago

This should be fixed in dev/next.

Anyone encountering can use restore files option to fix it on release.

-J