OctarineSourcerer / cyberpunk2020

A FoundryVTT system for Cyberpunk 2020. It's playable now! There's a lot of hole, because there's a LOT of system to cover, but it should be mostly usable <3
24 stars 22 forks source link

Character list issues #116

Open GuitarPyro opened 2 years ago

GuitarPyro commented 2 years ago

Good day.

So, after attempt to update foundry from 0.8.9 (which worked perfectly with CP system) to ANY stable v9 version (from build 238 and higher) got this problem (screenshot https://sun9-85.userapi.com/s/v1/if2/LEzNx2NsTgFFojew6UsZu3cOM-4t9G9n5HFyduZ_QCPCiXF3dP7T5OrimP1bHLPfZvNtKa1KYGiy77byKe2ckGjD.jpg?size=801x730&quality=96&type=album). This happens with any type of token, no matter what, NPC or player char. Also, none of the attack rolls can be recognized by Foundry - chat simply outputs "NaN" as a roll result, but skill checks works as usual.

A bit disappointed and had to return to 0.8.9, so now unable to use Foundry for some other systems that require V9 and higher.

EDIT: it seems that manual installation of latest version CP resolved some issues (like rolls) but whole bunch of modules didnt work.

Any tips how this can be fixed? Thanks.

OctarineSourcerer commented 2 years ago

Sorry for how late I'm replying here! Had a long weekend elsewhere, and am just getting back to things. I might need a couple things:

Do your sheets still look like that after the manual installation? The system should be compatible with v9, though it's possible other modules might not be.

GuitarPyro commented 2 years ago

Excuse me also being (very) late - got a lot of work last month.

So, I'm on Foundry V9 (Build 269) and latest (0.3.4 if I remember correctly) CP. Be honest, I forgot about checking console and and fully dived into the problem. I've managed to fix all things next day by simply redownloading and reinstalling everything by hand after checking some Foundry internals with "programming scalpel". Things start working properly, only minor cross-compatibility issues left (for example any of dice roller modules - we now use chat command to perform any dice roll that isn't tied to stat or smth else).

Also tried to replicate the issue on another machine - everything was like in my first post, so it seems for me that there might be some problems with autoinstaller pack or algorithm.

OctarineSourcerer commented 2 years ago

Seems like we're both on the late-to-things train! Do you mean problems with Foundry's auto-installation? As far as I can tell, the issue would either lie there or in this module's migration-between-package-versions code (which admittedly, I really should write some solid tests for)

GuitarPyro commented 2 years ago

It looks like Ive managed to achieve a stable repetition of first mentioned error!

This test was performed primarily with Foundry v10 (Build 284) and some late V9s. System somehow automatically adds -4 modifier when using "auto fire" or "three round burst" like as Im aiming at certain body location. When I tried to negate this by adding +4 at "Extra modifiers" nothing happened. Like literally - no rolls, no chat messages, nothing. Anything below or higher than+4 works. "Semi auto" rolls can be made only when specific location (like "head" or "right arm") is chosen, simply adding +4 does not the trick.

Any skills or stats rolls from list working normally.

EDIT: sorry for closing theme, just can't post a comment without it. However, if you want it - close this thread, I don't mind. Just wanted to report some newly found roots of issue.

OctarineSourcerer commented 2 years ago

So, I'm doing a little bit of development on CP2020 at the moment - mostly migrating to v10 of foundry, or at least hopping forward before the deprecated things crush the project. Alas, I tend to develop on this in short bursts as it's heavily in backburner territory.

The original URL with the screenshot doesn't work, but on trying to fire with full auto weapons in my current v10 migration branch, it seems to work (I've fixed a bug that melee weapons had with hit location selection, that might be related). Will put an update out when I thiiiiink v10 migrating shouldn't explode.