search

OctoPrint / OctoPrint-FirmwareUpdater

OctoPrint plugin for flashing pre-compiled firmware images to a 3D printer.
https://plugins.octoprint.org/plugins/firmwareupdater/
GNU Affero General Public License v3.0
353 stars 78 forks source link

Make marlin-binary-protocol install when plugin is installed #275

Closed fredrikbaberg closed 3 years ago

fredrikbaberg commented 3 years ago

Hardware Setup Creality Ender 3 Pro

Describe the problem I'm writing this as a response to https://github.com/fredrikbaberg/hassio-addons/issues/183. It would be useful if dependencies are installed when the plugin installs, in this case marlin-binary-protocol.

Log Files I haven't installed the plugin yet, so no log file available.

Additional context I've created a pull request, #274, which is currently a work-in-progress as I haven't tested it yet. The idea is to make sure the dependency is installed when the plugin installs, so that additional commands are not required.

benlye commented 3 years ago

This isn't possible due to the documented problem with installing heatshrink on Python3.

fredrikbaberg commented 3 years ago

Understood, I've just closed the PR and also closing this as I haven't figured out a solution.

github-actions[bot] commented 3 years ago

This issue has been automatically locked because there was no further activity after it was closed. Please open a new issue for any related problems.