OctoPrint / OctoPrint-Slic3r

Slic3r plugin for slicing within OctoPrint
GNU Affero General Public License v3.0
88 stars 30 forks source link

Update __init__.py #50

Closed sfjuocekr closed 5 years ago

sfjuocekr commented 5 years ago

Fixes using PrusaSlicer

eyal0 commented 5 years ago

This will break old slic3r versions, right?

Can you put a version check into the code and then branch depending on the version?

sfjuocekr commented 5 years ago

Probably, I think a simple checkbox to mark the use of PrusaSlicer would suffice in this case as well.

When the heat settles down I might look into it!

eyal0 commented 5 years ago

I worry that no one will find the checkbox and I'll be getting more bug reports. Why not just add a check in the code? Just run, like slic3r --version, look at the output, and determine which arguments to use based on that?

eyal0 commented 5 years ago

Fixed in #51