OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.
Other
12 stars 44 forks source link

Disposing an SslStream that leaves the inner stream open causes it to… #517

Closed sburmanoctopus closed 11 months ago

sburmanoctopus commented 11 months ago

… flush the stream.

But the underlying NetworkTimeoutStream throws an exception when it flushes and is in a faulted/timed out state.

That is what we are fixing.

Are you a customer of Octopus Deploy? Please contact our support team so we can triage your PR, so that we can make sure it's handled appropriately.

Background

Results

Fixes https://github.com/OctopusDeploy/Issues/issues/... (optional public issue)

Fixes https://github.com/OctopusDeploy/ResearchAndDevelopment/issues/... (optional private issue)

See How we use GitHub Issues (including this flowchart

Before

Before

After

After

How to review this PR

Quality :heavy_check_mark:

Pre-requisites