While looking into future .NET 8 support, I encountered some small issues in the tests. I've extracted these out of the .NET 8 work as they aren't connected to .NET 8 versioning
Results
Fix certificate tests which could fail due to a race condition between asserting a result, and the result being captured
Halibut.Tests.csproj referrred to TargetFramework net60 in one place, it should have been net6.0
Thread-safety in the SyncIoRecording classes in Halibut.Tests
Fix various null-safety warnings in Octopus.TestPortForwarder; this now builds cleanly
How to review this PR
Quality :heavy_check_mark:
These changes are all in the tests. By that definition, if the tests pass we should be good to merge.
I ran them all locally on my windows PC and they are all passing
Pre-requisites
[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.
Background
While looking into future .NET 8 support, I encountered some small issues in the tests. I've extracted these out of the .NET 8 work as they aren't connected to .NET 8 versioning
Results
Halibut.Tests.csprojreferrred to TargetFrameworknet60in one place, it should have beennet6.0Octopus.TestPortForwarder; this now builds cleanlyHow to review this PR
Quality :heavy_check_mark:
These changes are all in the tests. By that definition, if the tests pass we should be good to merge. I ran them all locally on my windows PC and they are all passing
Pre-requisites