OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.
Other
12 stars 44 forks source link

Remove proxy from client and service #570

Closed sburmanoctopus closed 10 months ago

sburmanoctopus commented 10 months ago

Background

If you want to get access to the proxy in your test (if you added one), then you have to use a nullable property on the "client and service".

This contract is limiting, as it is not clear when this nullable property will actually contain a value or not.

Results

Before

The proxy property will only include a value if you have called WithProxy

After

We make WithProxy optionally take an 'out' parameter so that the caller will know for sure that they have the correct reference to the proxy.

How to review this PR

Quality :heavy_check_mark:

Pre-requisites