We want to make it easier to detect an OperationCanceledException from consumers of Halibut (e.g. Tentacle Client).
Results
Before
All exceptions throw within the SecureListeningClient were wrapped in a HalibutClientException. Meaning consumers would have to 'unpack' the exception to see if it was an OperationCanceledException
After
We now throw an exception of the respective OperationCanceledException type instead.
Contractually, this should be fine for the consumer, as Polling tentacles will already throw OperationCanceledExceptions.
How to review this PR
Quality :heavy_check_mark:
Pre-requisites
[ ] I have read How we use GitHub Issues for help deciding when and where it's appropriate to make an issue.
[ ] I have considered informing or consulting the right people, according to the ownership map.
[ ] I have considered appropriate testing for my change.
[sc-66743]
Background
We want to make it easier to detect an
OperationCanceledException
from consumers of Halibut (e.g. Tentacle Client).Results
Before
All exceptions throw within the
SecureListeningClient
were wrapped in aHalibutClientException
. Meaning consumers would have to 'unpack' the exception to see if it was anOperationCanceledException
After
We now throw an exception of the respective
OperationCanceledException
type instead.Contractually, this should be fine for the consumer, as Polling tentacles will already throw
OperationCanceledExceptions
.How to review this PR
Quality :heavy_check_mark:
Pre-requisites