OctopusDeploy / Halibut

| Public | A secure communication stack for .NET using JSON-RPC over SSL.
Other
12 stars 44 forks source link

Make ServiceInvoker treat Nullable<T> parameters as a match for null arguments #604

Open khellang opened 5 months ago

khellang commented 5 months ago

Background

When passing null to an async service method accepting a Nullable<T> parameter, the call fails as Halibut will not consider the method a match.

Results

Fixes #603

Before

Passing null to a service method with a Nullable<T> parameter failed. See #603

After

Invoking the method no longer fails.

Pre-requisites

CLAassistant commented 5 months ago

CLA assistant check
All committers have signed the CLA.

khellang commented 4 months ago

Hello good folks! 👋 Any hint on when we can get this looked at? We've worked around it by splitting the RPC interface with different overloads with and without the nullable argument, but would really like a proper fix 😅