search

OdooCommunityWidgets / website_multi_image

Odoo Website Multi-Image Module
MIT License
29 stars 34 forks source link

Compatibility for Odoo 9.0 #37

Closed ryanc-me closed 8 years ago

ryanc-me commented 8 years ago

Hey @lukebranch,

Hopefully this what you meant! I've just double-checked, and everything is working well under Odoo v9. I also changed the folder structure slightly, I think having __opererp__ and __init__ in the root folder makes the module much easier to handle for both developers and end-users.

Let me know what you think!

lukebranch commented 8 years ago

@MGinshe ,

Thanks! I'll pull and review it now and get back to you with my comments.

ryanc-me commented 8 years ago

Hey @lukebranch,

I was just wondering where you're at with the PR?

lukebranch commented 8 years ago

@MGinshe ,

Sorry, I still have not yet had the chance to review it. I'm planning to review and merge on Sunday (Hong Kong Time) if I don't discover any issues.

lukebranch commented 8 years ago

@MGinshe ,

I've taken a look and it all seems to be fine. I have only one comment at the moment after a quick review, there seem to be some typos here:

these should be 'multi' not 'mutli'. If you get the chance it would be great if you could update the README.md file for the 9.0 branch as well (clone instructions, etc.).

Once i've heard back from you i'll merge. Thanks for the PR!

lukebranch commented 8 years ago

@MGinshe ,

I'll merge this for now and we can make improvements later, thanks for the PR!