infinite-persistence
commented
1 year ago - [x] Bad
reaction.Listloop- Will be closed by #2847
- [ ] The auto-fetching of first-level replies causes too many parallel
comment.List, which spawns parallelclaim_search,membership_check, etc.- All of them have these perform "filter out fetched IDs" loops (similar to Reactions above) which doesn't scale.
- Repro: scroll quickly on a page with many replies. CPU maxed for a long time (sometimes, I think it is stuck).
- I think this is the next biggest contributor, and hardest to fix given it touches various segments.
- [ ] Selector optimizations
- [ ] Get rid of
comment -> id -> commenttriple translation loops. - [ ] Reference invalidation of the secondary arrays, even when there are no changes.
- [ ] Blocklist filtering — figure out the least repetitive place to run it. It’s currently being run is the busiest place (selectors).
- Leaning towards just removing blocked items immediately after fetch.
- I assume it wasn't done that way because the blocklist could be cleared and we would have to re-fetch comments ... tradeoffs, I guess.
- [ ] Get rid of
- [ ] React optimizations
- [ ] Markdown parsing
- [ ] Emoji
- [ ] Mention autocomplete (showing up in profiler a lot)
http://localhost:9090/@AlphaNerd:8/the-earn-it-act-will-not-protect:1
Been noticing my CPU fan spinning like crazy lately. Few seconds would be fine, but 10s seems long.
Homepages have more tiles but doesn't show the problem. Since I also see this in livestreams, most likely it's due to comments or emojis. Would like to take a look.