Open shubham-betterworks opened 2 years ago
We are looking into this, we will get back to you.
@Meghana-MSFT any updates on this?
@shubham-betterworks - We were trying to repro your issue, could you please let us know if you are using Search based messaging extension or Action based messaging extension. Can you please share the repro steps?
@Meghana-MSFT it is an action based messaging extension.
"composeExtensions": [
{
"botId": "{{Microsoft-App-Id}}",
"commands": [
{
"id": "dynamicsearch",
"type": "action",
"title": "Dynamic Search",
"description": "Dynamic Search",
"initialRun": false,
"fetchTask": true,
"context": [
"compose"
]
}
]
}
],
Add the following messaging extension invoke handler in TeamsBot
handleTeamsMessagingExtensionFetchTask(context, action) {
const card = CardFactory.adaptiveCard(this.adaptiveCardForDyanamicSearch());
return {
task: {
type: "continue",
value: {
card
},
},
};
}
onInvokeActivity
method change last line return null
with return super.onInvokeActivity(context);
@Meghana-MSFT any updates?
We are also able to repro this issue, we are checking with the engineering team. We will update you.
@Meghana-MSFT any updates?
@shubham-betterworks - Apologies for the delay in response, A bug has been raised for the same. We will keep you posted on the updates.
Could you please share the below details as the engineering teams needs this information -
How did the customer initiate the ME flow? From engineering team's investigation, as long as the bot is added to a team or chat, and initiated the expected way, the ME works.
Add the bot --> Go to chat window with the bot --> Initiate the messaging extension command --> Search and select multiple options
ME pop-up opens. the issue is in the representation of selected items as shared in the screenshots
Could you please also let us know the scope of bot? Is it personal scope or to a group chat/team?
scope is personal
@shubham-betterworks - Engineering team has tested and confirmed that dynamic search does work on ME cards. Team has informed that the way the bot is created is the root cause of the issue. The bot should handle invoke of both "composeExtension/fetchTask" as well as dynamic typeahead invoke "application/search". Engineering team has shared the below sample as reference. https://github.com/deekshanya/typeaheadME
It is a private repo. Access will be shared as needed.
@Meghana-MSFT can you please give access to the repo which you shared?
Also just to clarify the Messaging extension pop-up opens and allows searching and selecting. The issue is with the UI. It doesn't show the items specified, instead it just shows x item(s) selected
.
@Meghana-MSFT waiting to get access to the GitHub repo
I requested for repo access to the engineering team.
Engineering team has shared the below guidance - For any dynamic choices chosen, it would have to be handled by the bot developer. This is because we don't retain any bot specific data currently.
Few recommendations for resolving this:
@shubham-betterworks - Please let us know if you still have any query or shall we close this issue ?
@ChetanSharma-msft I'm still getting the UI issue. Waiting for access to the GitHub repo to see what needs to be changed to get it working
@shubham-betterworks - I requested for the access, I will let you know once it is approved.
@ChetanSharma-msft, @Meghana-MSFT Still getting broken UI in messaging extension. When the adaptive card with dynamic search and multiple selections true is used in Messaging extension the UI doesn't show the selected data properly(only shows x items selected) whereas when the same card is sent as a message from the bot the result is different. Please refer to the video to see this behavior
@ChetanSharma-msft @Meghana-MSFT Selection clear button (X) is also not working. When we click on X
icon it opens the choices dropdown instead of clearing the selections.
Thank you for the video, we have shared the videos with engineering team. we will get back to you.
@Meghana-MSFT any updates???
We are checking with the engineering team for an update. Please be assured that I will post here as soon as I have an update from engineering team. Thanks.
Update : Engineering team has confirmed that they are actively working on the issue mentioned. We currently do not have an ETA to share.
Please find the below updates for issues mentioned in this thread and https://github.com/OfficeDev/Microsoft-Teams-Samples/issues/455
When the adaptive card with dynamic search and multiple selections true is used in Messaging extension the UI doesn't show the selected data properly(only shows x items selected) whereas when the same card is sent as a message from the bot the result is different - This is due to difference in one component being rendered by react and other by angular.
Selection clear button (X) is also not working. When we click on X icon it opens the choices dropdown instead of clearing the selections - Work item has been created to fix this issue.
When a default value is provided in the input.choiceset field with dynamic search functionality enabled in the adaptive card the messaging extension treats it as a placeholder and not an actual input value whereas the same card works fine when sent as a message from a bot in the chat - This is similar to 1st one, the issue is in difference of rendering. Team has said that if UI is the only bothering issue, parity will be maintained once everything is in react.
@Meghana-MSFT thanks for the updates.
So there two internal work items which will fix these issues
Point 1 and Point 3 and not just UI issues. They also impact the user experiences like the following scenarios
Also any ETA by when we can expect these issues resolved?
we currently do not have any ETA to share.
While using the dynamic typeahead search in a messaging extension with
isMultiSelect: true
the UI breaks and does not behave how it works in a standard adaptive card sent in the message.Issues
2 items selected
X
icon at the input doesn't clear the selections