OfficeDev / Office-Addin-Scripts

A set of scripts and packages that are consumed in Office add-ins projects.
MIT License
160 stars 100 forks source link

[patch] Update config to use es5 trailing comma rule and move dependency to dev #868

Closed millerds closed 5 months ago

millerds commented 5 months ago

Thank you for your pull request!

Please add '[major]', '[minor]', or [patch] to the title to indicate the impact the change has on the code. Please also provide the following information.


Change Description: When updating the eslint and prettier plugin versions a rule was changed to require trailing commas. We need to be compatible with older "es" version so setting the prettier config to that. Also move a dependency to lint to the dev section in another package

  1. Do these changes impact command syntax of any of the packages? (e.g., add/remove command, add/remove a command parameter, or update required parameters) No.

  2. Do these changes impact documentation? (e.g., a tutorial on https://learn.microsoft.com/office/dev/add-ins/overview/office-add-ins) No.

If you answered yes to any of these please do the following:

Include 'Rick-Kirkham' in the review Make sure the README file is correct

Validation/testing performed: Crated a test project with the prettier error and verify it was gone after updated package was used.