OfficeDev / microsoft-teams-library-js

JavaScript library for use by Microsoft Teams apps
https://docs.microsoft.com/microsoftteams/platform/
Other
434 stars 198 forks source link

`authenticate({isExternal: true})` doesn't open external browser from meeting side pannel #1472

Open jharinek opened 1 year ago

jharinek commented 1 year ago

We are aiming for implementing third party OAuth in our MS Teams app. For that we'd like to leverage the isExternal capability of authenticate SDK method. However it doesn't work as expected on desktop MS Teams app (macOS version) - it still opens just a popup inside Teams app when in meeting side panel. On the other hand, I was able to open external browser from tab configuration view of the app.

According to this guide it works only for mobile apps, however it seems that it refers to beta version of SDK.

Since SDK 2.0 is out of beta and documentation doesn't explicitly mention that the parameter shouldn't work on other platforms than mobile I am assuming it's a bug.

Could you please confirm if what we're trying to achieve is legitimate?

If that's a known missing functionality is there any ETA when it could be fully supported on desktop Teams app?

Thanks!

ghost commented 1 year ago

Hi jharinek! Thank you for bringing this issue to our attention. We will investigate and if we require further information we will reach out in one business day. Please use this link to escalate if you don't get replies.

Best regards, Teams Platform

Nivedipa-MSFT commented 1 year ago

@jharinek - We have tested this scenario. We have added isExternal property in authenticate method. From meeting sidepanel we are getting popup and from tab configuration view its opening in browser window.

We have raised a bug for the same. We will keep you posted if there are any updates on it.

Nivedipa-MSFT commented 1 year ago

@jharinek - We are actively checking the updates on this bug with engineering team and let you know as soon as possible.

Nivedipa-MSFT commented 1 year ago

@jharinek - We are actively checking the status of the bug with engineering team. We will let you know once we get any updates on it.