OfficeDev / microsoft-teams-library-js

JavaScript library for use by Microsoft Teams apps
https://docs.microsoft.com/microsoftteams/platform/
Other
425 stars 193 forks source link

Configurable Tabs no longer saving data in New Teams #2169

Open NuxXDev opened 6 months ago

NuxXDev commented 6 months ago

Our configurable Tabs in New Teams are no longer saving data. The initial save when the Tab is first added works, but any changes after that are not saved. It works fine in Classic Teams Desktop and Classic Teams Web.

Tested with microsoft/teams-js: 2.2.0 and 2.20.0

Steps to reproduce:

  1. Add new tab and click [Save]
  2. Go to Tab 'Settings' make a change such as 'contentUrl' and [Save] again.
  3. Leave Tab and return, it will load the old data not the new settings that were just saved.

microsoftTeams.pages.config.registerOnSaveHandler(saveEvent => { var configPromise = microsoftTeams.pages.config.setConfig({ websiteUrl: "https://yourWebsite.com", contentUrl: "https://yourWebsite.com/ListPage", entityId: "listTab", suggestedDisplayName: "Your List" }); configPromise.then(() => { saveEvent.notifySuccess(); // Returns success but does not save }).catch(error => { saveEvent.notifyFailure(error); }); });

https://learn.microsoft.com/en-us/microsoftteams/platform/tabs/how-to/create-tab-pages/configuration-page?tabs=teamsjs-v2

ChetanSharma-msft commented 6 months ago

Hello @NuxXDev - Thanks for raising your query. We will look into it and let you know the updates.

Meghana-MSFT commented 6 months ago

We checked this at our end by setting up the sample https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/app-hello-world/nodejs. We were able to save the settings properly and tab is being updated accordingly. It is working fine in both new Teams web/Desktop client.

https://github.com/OfficeDev/microsoft-teams-library-js/assets/81138249/d9a88fe1-4d7e-46a3-bda6-ffa69248e4eb

NuxXDev commented 6 months ago

@Meghana-MSFT

After loading the Tab, make a change and save it, then leave the Tab and return the change will not be saved that is the issue I am seeing. In your video you never left the Tab.

Meghana-MSFT commented 6 months ago

Could you please share a video of the issue? We left tab and returned. The changes are saved.

NuxXDev commented 6 months ago

@Meghana-MSFT

I have some more information. It seems to only happen when the Tab is added to a Chat. I noticed in your video you add the Tab to a Channel.

I was able to reproduce with the following sample app: https://github.com/OfficeDev/Microsoft-Teams-Samples/tree/main/samples/app-hello-world/csharp

https://github.com/OfficeDev/microsoft-teams-library-js/assets/32570858/20f59694-60d9-40af-99b1-acad2ca9315d

Meghana-MSFT commented 6 months ago

We are able to repro this issue, we raised a bug for the same. We will keep you posted. Thank you.

https://github.com/OfficeDev/microsoft-teams-library-js/assets/81138249/472b9f20-61e5-4955-8ad3-1ca1b4612310

NuxXDev commented 6 months ago

This post is missing the [BUG] label.

NuxXDev commented 2 months ago

Any updates on this issue?

Meghana-MSFT commented 2 months ago

Unfortunately, we do not have any updates to share. We are following up with engineering team for updates. We will keep you posted.