OfficeDev / teams-toolkit-samples

Scenario-focused sample applications that help you get started with building Microsoft Teams App.
MIT License
354 stars 244 forks source link

[Sample Onboard Request] Policies Graph connector #1323

Open waldekmastykarz opened 2 months ago

waldekmastykarz commented 2 months ago

Owner:

@waldekmastykarz @sebastienlevert

ID: nodejs-typescript-policies

Title: Policies Graph connector

Description: This sample project uses Teams Toolkit for Visual Studio Code to simplify the process of creating a Microsoft Graph connector that ingests data from a custom API to Microsoft Graph. It provides an end to end example of creating the connector, ingesting content and refreshing the ingested content.

Tags: TS, Graph connect, Azure Function, Copilot for Microsoft 365

Time: 10 mins to run

Configuration: Ready for local debug

Thumbnail: https://raw.githubusercontent.com/pnp/graph-connectors-samples/main/samples/nodejs-typescript-policies/assets/connector-copilot-results.png

(Source code NOT in this Repo) Sample URL: https://github.com/pnp/graph-connectors-samples/blob/main/samples/nodejs-typescript-policies/

summzhan commented 2 months ago

@waldekmastykarz Thanks for following our process, I will help you review and go through the testing process.

summzhan commented 2 months ago

@waldekmastykarz , I have reviewed your sample and it looks good to me, this sample is under checking by our testing team now. Still needs time for their feedback.

Only one minor suggestion is that in README file, it is better to put "Features" section right after sample "Summary" section: image image

Since people may want to understand the features first before they hands on to play with it. Also, it will make this sample looks more aligned with other samples in sample gallery regarding to the README structure.

waldekmastykarz commented 2 months ago

That's a great suggestion. I'll update it. Thank you

waldekmastykarz commented 2 months ago

Readme updated

hellyzh commented 2 months ago

@waldekmastykarz , I'd like to run the test for the sample but has no copilot access for my m365 test account. The MS tenant account has copilot access but has no access for Microsoft 365 admin portal. So the test is blocked. Do you know how to get the copilot access for my m365 test account?

waldekmastykarz commented 2 months ago

@hellyzh Sorry, I don't. To run the sample you don't necessarily need Copilot. This sample only contains a Graph connector. You can run the sample to ingest the content to your tenant. When it's done, you can verify that the content has been properly ingested via Microsoft 365 Search.

hellyzh commented 2 months ago

@waldekmastykarz We can run the sample according to the readme, but are still not able to validate the result. The result in copilot by navigating to Microsoft365.com/chat is showing as below. The content looks like not the one in readme. image If use Microsoft 365 Search to verify the content, no content can be found. I have set the Required actions column with selecting the link to Include Connector Results and confirm the prompt. image

waldekmastykarz commented 2 months ago

Since we've updated the sample to only include the Graph connector without a declarative agent, let me update the instructions to make that more clear. Sorry for the trouble and I appreciate your patience. I'll post an update when the sample is ready for a retest.

waldekmastykarz commented 2 months ago

I've updated the instructions and the sample is ready for retesting. Please let me know if I can help with anything

tecton commented 1 month ago

@summzhan Please help to define the type of this sample.

summzhan commented 1 month ago

@summzhan Please help to define the type of this sample.

@tecton I cannot tell either, @waldekmastykarz could you please tell us the type of this sample? like tab or bot or what else.

waldekmastykarz commented 1 month ago

It's a Microsoft Graph connector