search

Ogeon / rustful

[OUTDATED] A light HTTP framework for Rust
https://docs.rs/rustful
Apache License 2.0
862 stars 52 forks source link

Cleanup some warnings from Clippy #91

Closed mcarton closed 8 years ago

mcarton commented 8 years ago

For information, here is the log before and after with Clippy. Remaining warnings from Clippy are mostly false positive.

Ogeon commented 8 years ago

Ah, nice! Some, if not many, of those are old relics from when Rust was different... Nice to see them being found and cleaned out. I guess I should start checking with Clippy from time to time.

Some of the remaining ones are most likely necessary or doesn't really matter, but at least the last once about &Vec<...> sounds like it can be safely fixed. I can't imagine a reason for doing like that, except a brain slip. I'm fine with leaving them as they are for now, unless you want to give it another go.

mcarton commented 8 years ago

I wasn't sure about that one since it changes some public interface.

Ogeon commented 8 years ago

No, that one is safe to change. I have hidden it from the docs and written a warning.

Ogeon commented 8 years ago

The tests are nice and green. Thank you!

@homu r+

homu commented 8 years ago

:pushpin: Commit 7986f31 has been approved by Ogeon

homu commented 8 years ago

:zap: Test exempted - status