Fixes up bugged up rods

Oheers / EvenMoreFish

An advanced fishing plugin based on MoreFish, created 2 years after its last update.

MIT License

96 stars 60 forks source link

Fixes up bugged up rods #481

Closed DavidDoesCode closed 2 weeks ago

DavidDoesCode commented 2 weeks ago

Backwards Compatibility: Fixes bugged up rods. They became bugged up if they encountered a (now fixed) nbt conversion bug. The rod would have been enchanted, had lore, or extra nbt data. It was possible to apply baits to these rods, but it would not show up in the lore. The bait was also not consumed.

Before:

emf-applied-bait:",Shrimp:5"

After:

emf-applied-bait:"Shrimp:5"

We shouldn't be expecting a bait name to start with , so this should be fairly safe.

DavidDoesCode commented 2 weeks ago

PS to "unbug" a rod, simply apply a bait to it. The lore and nbt should all be matching up now.

DavidDoesCode commented 2 weeks ago

I'm going to reimplement this so only the current bait get applied instead of the duped invisible ones staying.