Oheers / EvenMoreFish

An advanced fishing plugin based on MoreFish, created 2 years after its last update.
MIT License
96 stars 60 forks source link

[Suggestion (Plugin)]: 1.21 thru 1.21.3 support #482

Closed lostofficial closed 2 weeks ago

lostofficial commented 2 weeks ago

Suggestion

1.21 seems to work fine. However, support 1.21.1, 1.21.2, and 1.21.3 should be added. Currently, the plugin gets disabled with an error thrown in console. The error sent is below:

[12:36:09 INFO]: [NBTAPI] [NBTAPI] Using the plugin 'EvenMoreFish' to create a bStats instance!
[12:36:09 ERROR]: Error occurred while enabling EvenMoreFish v1.7.3 (Is it up to date?)
java.lang.RuntimeException: NBT-API wasn't initialized properly, disabling the plugin
        at even-more-fish-1.7.3-RELEASE.jar/com.oheers.fish.EvenMoreFish.onEnable(EvenMoreFish.java:130) ~[even-more-fish-1.7.3-RELEASE.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:288) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:202) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:643) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:592) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:767) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:529) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:326) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1233) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:339) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
[12:36:09 INFO]: [EvenMoreFish] Disabling EvenMoreFish v1.7.3
[12:36:09 ERROR]: Error occurred while disabling EvenMoreFish v1.7.3
java.lang.NullPointerException: Cannot invoke "com.oheers.fish.config.MainConfig.isDatabaseOnline()" because the return value of "com.oheers.fish.config.MainConfig.getInstance()" is null
        at even-more-fish-1.7.3-RELEASE.jar/com.oheers.fish.EvenMoreFish.lambda$saveUserData$19(EvenMoreFish.java:485) ~[even-more-fish-1.7.3-RELEASE.jar:?]
        at even-more-fish-1.7.3-RELEASE.jar/com.oheers.fish.EvenMoreFish.saveUserData(EvenMoreFish.java:497) ~[even-more-fish-1.7.3-RELEASE.jar:?]
        at even-more-fish-1.7.3-RELEASE.jar/com.oheers.fish.EvenMoreFish.onDisable(EvenMoreFish.java:243) ~[even-more-fish-1.7.3-RELEASE.jar:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:291) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.disablePlugin(PaperPluginInstanceManager.java:237) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.disablePlugin(PaperPluginManagerImpl.java:114) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at org.bukkit.plugin.SimplePluginManager.disablePlugin(SimplePluginManager.java:550) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperPluginInstanceManager.enablePlugin(PaperPluginInstanceManager.java:206) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.enablePlugin(PaperPluginManagerImpl.java:109) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:520) ~[paper-api-1.21.3-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.CraftServer.enablePlugin(CraftServer.java:643) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at org.bukkit.craftbukkit.CraftServer.enablePlugins(CraftServer.java:592) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at net.minecraft.server.MinecraftServer.loadWorld0(MinecraftServer.java:767) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at net.minecraft.server.MinecraftServer.loadLevel(MinecraftServer.java:529) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at net.minecraft.server.dedicated.DedicatedServer.initServer(DedicatedServer.java:326) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1233) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:339) ~[paper-1.21.3.jar:1.21.3-15-99f4bb2]
        at java.base/java.lang.Thread.run(Thread.java:1583) ~[?:?]
lostofficial commented 2 weeks ago

Disregard - I have found the devbuild. Thank you.