OiWorld / CarbonFootprint

A Google Chrome browser extension that displays carbon footprint information in Google Maps.
34 stars 33 forks source link

Yellow Colour makes links hard to see in the "Know More" pages #118

Open ceilican opened 8 years ago

AnandKumar22 commented 7 years ago

Instead of giving it any color can we make some small transition type while hovering like scaling the menu or changing the background of the nav.....I think this would surely work out..

ceilican commented 7 years ago

Links should be visible even before the user decides to hover on them. So, yellow should definitely be replaced by a better color. Whoever decides to fix this issue should study a little bit of color theory, in order to choose an elegant and visible color.

It is usually not elegant to have special effects when hovering. I would not recommend that.

AnandKumar22 commented 7 years ago

Guys,sorry for such silly disturbances but I am not able to get the Html,CSS file of this project. Could anyone help me out with this I want to contribute in the front-end work. Thank You. ᐧ

On Wed, Jan 4, 2017 at 11:31 AM, Bruno notifications@github.com wrote:

Links should be visible even before the user decides to hover on them. So, yellow should definitely be replaced by a better color. Whoever decides to fix this issue should study a little bit of color theory, in order to choose an elegant and visible color.

It is usually not elegant to have special effects when hovering. I would not recommend that.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/OiWorld/CarbonFootprint/issues/118#issuecomment-270300680, or mute the thread https://github.com/notifications/unsubscribe-auth/AULHJV7oiWIC-n_R_21uK5c_29RR5I75ks5rOzXVgaJpZM4KUYFM .

--

Anand Kumar

Department of Electrical Engineering

Senior Executive Member

Gopali Youth Welfare Society https://t.yesware.com/tl/8652101a875e7848867f28b77cfb77736b59fa20/01a9a24b8f6b1ed14c943a36b55f4b95/e907594b1d46c1276f56a47875652f50?ytl=http%3A%2F%2Fwww.gyws.org%2Findex.php | IIT Kharagpur https://t.yesware.com/tl/8652101a875e7848867f28b77cfb77736b59fa20/01a9a24b8f6b1ed14c943a36b55f4b95/26e1344e1f518d4ff93b7f1145b59d1d?ytl=http%3A%2F%2Fwww.iitkgp.ac.in%2F

+91 9609800262 |ak8574779@gmail.com ak8574779@gmail.com

Facebook https://www.facebook.com/profile.php?id=100004216540300 | LinkedIn https://www.linkedin.com/in/anand-kumar-1480b6113?trk=nav_responsive_tab_profile

boro741 commented 7 years ago

https://github.com/OiWorld/CarbonFootprint/tree/master/Source/Core/pages

ceilican commented 7 years ago

Also, there are many tutorials on how to use git and GitHub out there. Make sure you read those. You should do the following steps:

  1. fork this repository
  2. clone your fork into your own local computer
  3. make the changes you want in the files in your computer
  4. commit and push your changes to your fork
  5. make a pull request through GitHub
AnandKumar22 commented 7 years ago

I have tried to solve this issue please have a look at the pull request and comment if further modification is needed..

ceilican commented 7 years ago

I left a comment in the code...

AnandKumar22 commented 7 years ago

@sanket0211 please have a look at the air index page,it has a problem regarding the positioning of the gray background box and the menu options. @ceilican I think that for that page it already has a map,so we should leave the background blank.I think that will look better rather than any gray or black background. screenshot 25 screenshot 24