Replace 'Gasoline' term with 'Petrol' based on their location.

[boro741]

As in India also in some countries like UK Gasoline is referred as Petrol. So replacing the term based on their location would ease people in understanding.

[ceilican]

That's a great idea!

Are you planning to implement it?

[boro741]

Yeah I'm planning for it.

[ceilican]

Ok. Thanks! Here are some tips:

1) I think it is better to make the fuel name depend on the user's "language/locale" preferences, rather than his/her location. For example, if the user has "en-UK" as his locale, he would still prefer to see "petrol" instead of "gasoline", even if he is currently located in the US.

2) @PrateekGupta1509 created a mechanism to allow internationalization/localization of the options page based on locales. Please use his mechanism.

Good luck!

[boro741]

Thanks! That's a great hint for me to start.

[boro741]

Now I would be allowing petrol to display when the user selects Imperial and Gasoline when they select the US.

And for a metric should I keep both?

[ceilican]

Hi @boro741 ! Thanks for the screenshot. I like how it is looking. Maybe we should simply keep both "Petrol" and "Gasoline" as options independently of what the unit system chosen by the user?

[boro741]

I've added Petrol to the list. But I don't know what broken when the map is opened it doesn't automatically pop-up on a new tab.

Here's the link I made changes to the file.

[Kolpa]

That only happens if you never saved your settings, After saving them once you can open the settings again by clicking the extension icon and selecting options in the pop-up.

[boro741]

ok got it. Thank you @Kolpa

[boro741]

Solution to this PR

[ceilican]

Thanks!