search

OiWorld / CarbonFootprint

A Google Chrome browser extension that displays carbon footprint information in Google Maps.
34 stars 33 forks source link

Added a favicon image #131

Closed AnandKumar22 closed 7 years ago

ceilican commented 7 years ago

Hi @AnandKumar22 ! Have you checked that the icon is free? What is its license?

AnandKumar22 commented 7 years ago

Actually I am not getting why popup.html page has been made? What will be the content of the page. Please let me know so that I can work on the front-end of that page. Thank You. ᐧ

On Sat, Jan 7, 2017 at 10:24 AM, Bruno notifications@github.com wrote:

Hi @AnandKumar22 https://github.com/AnandKumar22 ! Have you checked that the icon is free? What is its license?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/OiWorld/CarbonFootprint/pull/131#issuecomment-271063124, or mute the thread https://github.com/notifications/unsubscribe-auth/AULHJb4DB_MSWf0riGkSwOKWFlnUpV45ks5rPxqYgaJpZM4LdU1y .

--

Anand Kumar

Department of Electrical Engineering

Senior Executive Member

Gopali Youth Welfare Society https://t.yesware.com/tl/8652101a875e7848867f28b77cfb77736b59fa20/01a9a24b8f6b1ed14c943a36b55f4b95/e907594b1d46c1276f56a47875652f50?ytl=http%3A%2F%2Fwww.gyws.org%2Findex.php | IIT Kharagpur https://t.yesware.com/tl/8652101a875e7848867f28b77cfb77736b59fa20/01a9a24b8f6b1ed14c943a36b55f4b95/26e1344e1f518d4ff93b7f1145b59d1d?ytl=http%3A%2F%2Fwww.iitkgp.ac.in%2F

+91 9609800262 |ak8574779@gmail.com ak8574779@gmail.com

Facebook https://www.facebook.com/profile.php?id=100004216540300 | LinkedIn https://www.linkedin.com/in/anand-kumar-1480b6113?trk=nav_responsive_tab_profile

ceilican commented 7 years ago

Could you post here a screenshot of the changes you have made to the frontend/UI? Only then I will be able to approve the pull request.

ceilican commented 7 years ago

Also, what is the license of the favicon that you used?

ceilican commented 7 years ago

Actually I am not getting why popup.html page has been made?

popup.html appears when the user clicks on the extension's icon on the toolbar. In popup.html, the user has the option of choosing between "Options" and "Know More".

What will be the content of the page.

You can see it for yourself, by running the extension and clicking on the extension's icon.

AnandKumar22 commented 7 years ago

Sorry for the chores and confusion generated. I'll make sure that this doesn't happen again. By the way I am extremely excited to contribute in the issue of "Yellow color tabs are not visible" could you please elaborate it. There is a small confusion regarding it so could you please explain what it exactly is and suggest the way to solve it. Also I would like to solve the issue of popup.html which is there since long time so if you could suggest the content of that page then it would be easy to design the page as soon as possible because the page is like the incomplete one with 2 tabs at the left corner and there purposes are not being served. Also I was thinking that if we could generate the graph of the data and calculation then it would be much easier to analyze, I have done a bit of work on this, you may have a look at an issue generated by Rohit and please do suggest us further changes I think that this could be a good implementation in the extension i.e. generating the graph. Thank You.

ceilican commented 7 years ago

Thanks for adding the PDFs. However, you should have created a separate pull request for that.

This merge request has many unrelated changes. As long as one of the changes cannot be merged for some reason, I am not able to accept the merge request as a whole. To maximize the chances of your contributions between merged, you should submit one separate merge request per contribution.