Oksydan / falcon

Prestashop starter theme that provides great development experience.
GNU General Public License v3.0
264 stars 63 forks source link

🐛 [BUG] - [FIX] the gdpr checkbox doesn't appear in the product comment form #276

Closed maofree closed 1 year ago

maofree commented 1 year ago

Description

Hi

I've seen that the gdpr checkbox doesn't appear in the comment form

it is missing this code in the file post-comment-modal.tpl

<div class="form-group"> {hook h='displayGDPRConsent' mod='psgdpr' id_module=$id_module} </div>

also the checks have problems, it is necessary some css code to fix it

1

`div[class^="gdprmodule"] .custom-checkbox, .gdpr_consent .custom-checkbox { position: relative; }

div[class^="gdprmodule"] .custom-checkbox input[type="checkbox"], .gdpr_consent .custom-checkbox input[type="checkbox"] { position: absolute; width: 18px; height: 18px; margin-top: 0.25rem; cursor: pointer; opacity: 0; }

div[class^="gdprmodule"] .custom-checkbox input[type="checkbox"] + span, .gdpr_consent .custom-checkbox input[type="checkbox"] + span { display: inline-block; width: 1.125rem; height: 1.125rem; margin-right: 0.5rem; vertical-align: middle; pointer-events: none; cursor: pointer; border: 1px #979797 solid; }

div[class^="gdprmodule"] .custom-checkbox input[type="checkbox"]

div[class^="gdprmodule"] .custom-checkbox input[type="checkbox"]:checked

div[class^="gdprmodule"] .custom-checkbox input[type="checkbox"]:focus + span, .gdpr_consent .custom-checkbox input[type="checkbox"]:focus + span { border-color: #7a7a7a; }

div[class^="gdprmodule"] .custom-checkbox label, .gdpr_consent .custom-checkbox label { text-align: left; }`

bye

Node.js version

v16

php version

8.1

OS and it's version

linux

Browsers

Chrome

Required module/theme

theme

Reproduction steps

install gdpr module and productcomments just to test them

Logs

No response

maofree commented 1 year ago

I had to reset the gdpr module because it was not present in the displayGDPRConsent hook and then go inside the module and push on save button

I've found a problem on the check

1

maofree commented 1 year ago

I've seen that in the last version, the 6.0.2 has same changes, try to look at product-comments-list.tpl

Oksydan commented 1 year ago

Hi @maofree,

thank you for creating an issue. I was able to reproduce the problem.

Oksydan commented 1 year ago

Hi @maofree,

problem has been fixed. Thank you for creating an issue.