search

Oksydan / falcon

Prestashop starter theme that provides great development experience.
GNU General Public License v3.0
264 stars 63 forks source link

🐛 [BUG] - HTML lang is not set #277

Closed cdigruttola closed 1 year ago

cdigruttola commented 1 year ago

Description

The lang attribute in HTML is not set. I checked also the online demo and the problem is present. In localhost environment the problem is not reproduced.

Node.js version

v16.18.1

php version

v8.1

OS and it's version

MacOS Ventura

Browsers

No response

Required module/theme

theme

Reproduction steps

1. Go to 'layout-both-column.tpl' to check the correct valorization of attribute
2. In demo Online Inspect element
3. See the missing lang attribute in HTML tag

Logs

No response

Oksydan commented 1 year ago

Hi @cdigruttola,

I was able to reproduce an issue. This problem i related to is_themecore module and hook hookActionOutputHTMLBefore. We are passing html document there with DOMDocument and in this process lang attribute is being removed. I will fix in next version.

cdigruttola commented 1 year ago

Hi, do you have a dead line for this new version? I tried to check the class but I cannot understand why in the $params['html'] the lang attrbute is present but when you do $doc->loadHTML('' . $html) the attribute is missing.

Oksydan commented 1 year ago

Hi @cdigruttola,

new version has been released and bug has been fixed https://github.com/Oksydan/is_themecore/releases/tag/v4.1.1| Thank you for your contribution.