search

Oksydan / falcon

Prestashop starter theme that provides great development experience.
GNU General Public License v3.0
264 stars 63 forks source link

🐛 [BUG] - BIG problem with child theme - only the theme.css and theme.js files are loaded, the other three types of files are not loaded listing, product and checkout #341

Open maofree opened 1 year ago

maofree commented 1 year ago

Description

Hi now I've seen that there is a big problem with child theme only the theme.css and theme.js files are loaded, the other three types of files are not loaded listing, product and checkout

I solve the problem by copying the 6 files into the child theme. is_themecore should manage these 6 files, in case a child theme is used, perhaps by adding an option in its configuration page. given that the name of the main theme could have a different name, it might be simpler to add an option where, if activated, it loads the other files

1 2

the goal is to create a main theme and then various child themes to insert the customizations inherent to the various sites. this allows to easily update various websites

bye

Node.js version

v16

php version

8.1

OS and it's version

linux

Browsers

Chrome

Required module/theme

is_themecore, theme

Reproduction steps

1. create a child theme
2. enable it
3. look at the source code of the front-office

Logs

No response

Oksydan commented 1 year ago

Hi @maofree,

I am aware of this problem. We are going to refacto is_themecore in verison 5 of the module. We are going to use parent assets.yml when use_parent_assets is set to true.