search

OleMchls / atom-wordcount

Counts the words in your current document
https://atom.io/packages/wordcount
MIT License
38 stars 27 forks source link

Won't count the greek words #117

Closed IonianIronist closed 5 years ago

IonianIronist commented 5 years ago

I don't know if there is an issue with other alphabets (guess it's an encoding problem), but it doesn't seem to count words written in Greek at all, although it counts the characters.

davidlday commented 5 years ago

Could you post some sample text with expected word and character counts?

IonianIronist commented 5 years ago

Screenshot_1 αβαθείς αβαθές άβαθες αβαθή άβαθη expected 5 words , got 0

davidlday commented 5 years ago

Greek characters weren't covered originally. I'll see if I can add them.

davidlday commented 5 years ago

@IonianIronist - Quick question. Do you mean modern Greek only, or ancient Greek as well? See this SO question for reference: https://stackoverflow.com/questions/2502274/greek-characters-regular-expressions-and-c-sharp

IonianIronist commented 5 years ago

Well, I only ever write modern Greek and use Atom for some of my school projects. Also cant imagine anyone wanting to write ancient Greek in Atom, but sure there will be like that one weird guy. The only difference between the two are the accents as far as I'm aware witch should be these : https://en.wikipedia.org/wiki/Greek_Extended

davidlday commented 5 years ago

@IonianIronist - I'm so sorry for the long delay in getting this merged. No excuse. I simply got distracted. Merging the PR now.