`Common::getFilesInFolder` is not functional on non-Windows platform

Olganix / Sw_Racer

Tools relative to Starwars Racer.

Other

16 stars 2 forks source link

`Common::getFilesInFolder` is not functional on non-Windows platform #41

Closed JayFoxRox closed 6 years ago

JayFoxRox commented 6 years ago

I can't compile or use Sw_Racer anymore since this function was added. There is also no reason to ever need this sort of function either.

When repacking files, we should just open the proposed out_modelblock.bin.xml ( #18 ) [I assume listFiles.xml has the same purpose?] and then repack all files which it mentions.

I don't see why we should ever have to scan a folder for files - I think this is bad software design and we should avoid Common::getFilesInFolder.

JayFoxRox commented 6 years ago

Worked around by using dirent. I still believe we should get rid of this "folder scanning" code.

But this original issue has been solved. Closed.