search

Olical / depot

Find newer versions of your dependencies in your deps.edn file
https://clojars.org/olical/depot
The Unlicense
256 stars 14 forks source link

netty old version check broke between 2.1.0 and 2.2.0 #52

Open hoxu opened 3 years ago

hoxu commented 3 years ago

Depot 2.2.0 no longer notices that io.netty/netty-transport-native-kqueue is outdated.

deps.edn snippet:

           ^:depot/ignore
           io.netty/netty-transport                             {:mvn/version "4.1.60.Final"}
           ^:depot/ignore
           io.netty/netty-transport-native-epoll                {:mvn/version "4.1.60.Final"}
           io.netty/netty-transport-native-kqueue               {:mvn/version "4.1.60.Final"}
           ^:depot/ignore
           io.netty/netty-codec                                 {:mvn/version "4.1.60.Final"}
           ^:depot/ignore
           io.netty/netty-handler                               {:mvn/version "4.1.60.Final"}
$ clj -Sdeps '{:deps {olical/depot {:mvn/version "2.2.0"}}}' -m depot.outdated.main
...
Checking for old versions in: deps.edn
  All up to date!
$ clj -Sdeps '{:deps {olical/depot {:mvn/version "2.1.0"}}}' -m depot.outdated.main
...
Checking for old versions in: deps.edn
  io.netty/netty-transport-native-kqueue {:mvn/version "4.1.60.Final"} -> {:mvn/version "4.1.63.Final"}
Olical commented 3 years ago

Oh this is probably because of the CI job that was added that updates all the deps optimistically. I've never been a fan of updating automatically and I guess I've just been reminded why.

I'll try to revert it and do the deploy dance soon. Just need to find some time.

hoxu commented 3 years ago

On the bright side, the automated update found a case that does not yet have automated tests! Regardless of whether you disable the autoupdate, writing a test case for this is probably a good idea :)

Olical commented 3 years ago

So it's almost definitely not an issue with version-clj, more like it used to provide the wrong information to us and now it's fixed which stopped it working through depot. This answer from the author is great! https://github.com/xsc/version-clj/issues/17#issuecomment-817289374

So I'll try to use this info to fix it up in depot soon, but if someone beats me to it then I'll be damn happy to merge it. I've been bug fixing all day so far and I'm back to work after some time off tomorrow, so I'll be putting this down for at least a few days 🙂 (house work and then actual rest beckon!)