search

OliveStudio / olivemenus

A powerful menus plugin for Craft CMS built for the need of simplicity and flexibility
MIT License
40 stars 22 forks source link

Feature/run migrations #45

Closed niektenhoopen closed 4 years ago

niektenhoopen commented 4 years ago

Closes #41 Closes #42 Closes #43 Closes #44

niektenhoopen commented 4 years ago

I am not sure if this fixes all issues that were created in 1.1.7 but at least some of them. I think you are probably able to tell if there are more.

alinistrate commented 4 years ago

Hi @niektenhoopen Can you please pull the latest version now and do the fixes? There are some conflicts with what I did and I cannot pull the changes.

niektenhoopen commented 4 years ago

@alinistrate I see you also started fixing the issues. Feel free to use any of the above. I think I improved some bits (the migrations and getting the current site handle in the Controller if none is set so that the current URL without siteHandle keeps working). Open to discussion

edit: We replied at the exact same time :) I can make some changes

alinistrate commented 4 years ago

@niektenhoopen Thank you! Please do another pull request. I will review and merge. Also bump the version to 1.1.10

Thanks, Alin

alinistrate commented 4 years ago

@niektenhoopen Thank you. Really glad that people are using the plugin and it's useful. Initially, we developed the plugin for our internal use.

The help contributing to this is much appreciated.

Thanks, Alin