search

OlivierTD / team-rocket

Team Rocket working on OSS AntennaPod
MIT License
1 stars 1 forks source link

Custom theme functionality2 #163

Closed anania-y closed 6 years ago

anania-y commented 6 years ago

Added description to buttons as per review from last PR

Buttons now change some color in the app

anania-y commented 6 years ago

Button colors can't change since they are .png files. They are icons that are in the android code, cannot be changed color.

Theme is not saved no, maybe can implement this for the future? Action bar color change cannot be done with our current API (10), needs 11. However I have included the code to do so.

OlivierTD commented 6 years ago

Why when I change from the dark and light preset the color of the action bar changes? So are the buttons. And when you pick a color on your page you change the colors of the buttons.

What I meant by button is not the .png icons, its these

anania-y commented 6 years ago

to change the action bar color, you need to play around with the styles in the resource files. OR use the code that I wrote that won't work on this API.

As for the buttons, sorry misunderstood you. Will create issues to fix them in the future

164

OlivierTD commented 6 years ago

In some of my previous code, I use stuff that requires API 11 so I do not see the problem with the API.