OllisGit / OctoPrint-FilamentManager

OctoPrint plugin to manage your filament inventory
GNU Affero General Public License v3.0
53 stars 24 forks source link

Changing number of extruders permanently affects the number of filament manager tools #79

Closed techfreek closed 3 years ago

techfreek commented 3 years ago

Describe the bug As part of testing an integration of this plugin into OctoScreen (https://github.com/Z-Bolt/OctoScreen/pull/315) I modified my OctoPrint settings to say I had 2 extruders to see what the UI looked like. I saw the results, was content, and changed OctoPrint back to 1 extruder. Ever since, I've seen that the "plugin/filamentmanager/selections" endpoint still returns 2 tools. This is even after rebooting and even upgrading to OctoPrint 1.7

Steps to reproduce

  1. Open Settings
  2. Click on Printer Profiles
  3. Edit the active Profile
  4. Click on Hotend & Extruder
  5. Change to 2 extruders
  6. Save
  7. Check the output of "plugin/filamentmanager/selections"
  8. Repeat steps 1-4
  9. Change extruders to 1
  10. Save
  11. See that "plugin/filamentmanager/selections" still returns 2 tools

To check the output of the "plugin/filamentmanager/selections" endpoint, I used chrome dev tools to "Copy as cURL" and run that.

Expected behavior "plugin/filamentmanager/selections" returns the correct number of tools

Did the same happen when all other 3rd party plugins are disabled? Have not tested

Log file No logs related to filament manager

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

OllisGit commented 3 years ago

Hi @techfreek, new version 1.9.0 now only response with the max tool count selection.

Please test and give feedback Olli

techfreek commented 3 years ago

Thanks @OllisGit ! Looks like it is is correctly returning 1 selection now. Looks like the only remaining issue is in my WIP integration for OctoScreen. I'll work on fixing that, but this bug can be called fixed. Thanks!