Olyno / skent

Manage your files and folder with Skript
GNU General Public License v3.0
11 stars 2 forks source link

Add "output" keyword to "with logs" param when executing a file #30

Closed triblox closed 2 years ago

triblox commented 2 years ago

Describe your problem

My py.bat is not executed by the skript command but the game and the game lithener say that it is.

Versions

Skript: 2.6 (/ver skript) Server: Paper 1.18.1 (/ver) Skent: 3.1.0 (/ver skent)

Code

command /testbar:
  permission : neon.admin
  trigger:
    set {_files::*} to all files of dir path "python"
    send "Wow Skript has %amount of {_files::*}% files: %{_files::*}%"
    if file path "python/py.bat" is executable file:
      send "vote neon"
    else:
      send "noon"
    execute file path "python/py.bat"
    send "File executed! I'm now a hacker!"

on file execute:
  broadcast "votez neon"
#!/bin/bash

echo "Hello World"
touch test.txt

Error

image

Olyno commented 2 years ago

Hi 👋🏻 Thanks you for your report. Actually your code is a shell code and not a bat code. Could you retry but using execute file path "python/py.sh" instead? (and so rename the extension of the file). Also, because it's shell code and not bat code, it wouldn't work on Windows. Windows can't run shell code without any third party program.

triblox commented 2 years ago

hi ! Do you have discord ? I'm on linux , has you can see in the send message of my list file in the chat i already test it but with the same issue (that nothing append). Tanks for answer so quicly !

Olyno commented 2 years ago

There is a discord to support people about Skent, available just here

triblox commented 2 years ago

SOLVED BY :

change in my skript: execute file path "python/py.bat" to execute file path "python/py.sh" with logs

Clarify by Olyno :

Just to clarify: the with logs param let you bind the output of any program with the minecraft console, that's why you didn't have the output available Maybe it could be good to add with output optional, so people can use with output or with logs

The echo will chow with logs :

image

Note that the root path is the same that your ./start.sh so i change my py.bat to py.sh (to execute shell) and :

#!/bin/bash

echo "Hello World"
touch python/test.txt
Olyno commented 2 years ago

I reopen the issue but change it to suggestion/new feature, because the developer experience is something important, and the confusion with with logs can be annoying.

Olyno commented 2 years ago

Closing this issue because the keyword is already available.