One9398 / vimwiki

Automatically exported from code.google.com/p/vimwiki
0 stars 1 forks source link

Vimwiki2HTMLBrowse fails because of single quoted path in Windows #400

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1.Open gvim
2.<leader>ww (open wiki index)
3.<leader>whh (opens browser with page)
3b. :set ssl? (yields "noshellshlash")
4.follow link from index to another wiki using <Enter> on that link
5.<leader>whh (ERROR)
5b. :set ssl? (yields "shellshash")
6.:bn (go back to index)
7.<leader>whh (ERROR)
7b. :set ssl? (yields "shellshash")
8. :set nossl
9. <leader>whh (ERROR)
9b. :set ssl? (yields "shellshash")

I could only reproduce this problem on my machine. My limited poking around 
seems to yield that this only happens when shellshash is enabled. However, it 
seems like vimwiki is what is enabling shell slash, at least after I follow my 
first link by hitting <Enter> on a link.

What is the expected output? What do you see instead?
cmd prompt should be generated with:
C:\Windows\system32\cmd.ece /c start "Title" /B "C:/<path>/index.html"

What I see instead is a cmd prompt with:
C:\Windows\system32\cmd.ece /c start "Title" /B 'C:/<path>/index.html'
Along with a windows error message saying that it cannot find the path. Pasting 
this same command in with double quotes instead of single will fix the error.

What version of the product are you using? On what operating system?
2.0.1'stu'
Windows7-64bit

Please provide any additional information below.
shellescape() seems to be the function that generates the single quotes, and it 
seems to do this based upon shellslash aka ssl

Original issue reported on code.google.com by mmbra...@gmail.com on 26 Feb 2013 at 7:22

GoogleCodeExporter commented 8 years ago
This looks to be a compatibility error with miniBufExpl. When I open the second 
wiki page, then miniBufExpl is automatically loaded and it enables shellslash.

Original comment by mmbra...@gmail.com on 26 Feb 2013 at 10:12

GoogleCodeExporter commented 8 years ago
So what is your conclusion? I personally do not want to make my_shellescape()...

Original comment by habamax on 28 Feb 2013 at 2:48

GoogleCodeExporter commented 8 years ago
My conclusion is that nothing needs to change in VimWiki. It is an issue on 
miniBufExpl's end. They have several issues on there issue tracker dealing with 
this and it is supposed to be fixed in the next release.
See:
1. https://github.com/fholgado/minibufexpl.vim/issues/51
2. https://github.com/fholgado/minibufexpl.vim/issues/74

Original comment by mmbra...@gmail.com on 28 Feb 2013 at 11:27

GoogleCodeExporter commented 8 years ago
Okay, thx

Original comment by habamax on 1 Mar 2013 at 4:01