One9398 / vimwiki

Automatically exported from code.google.com/p/vimwiki
0 stars 1 forks source link

Executes customwiki2html is annoying #406

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Since `vimwiki#html#CustomWiki2HTML` executes the script through `execute 
!(script ...)`.
The "Press ENTER or type command to continue" prompt is show.
These is annoying when execute `VimwikiAll2HTML`, especially at the first time.

I think it is better to use `echom system(script ...)` instead.

BTW, what should I to when I contribute code unrelated to pandoc?
Should I attach the patch? Or push it to a new branch?
Thanks.

Original issue reported on code.google.com by themacropodus@gmail.com on 18 Mar 2013 at 4:37

GoogleCodeExporter commented 8 years ago
Small(subjective) changes that you think would make vimwiki better and you have 
tested them should be pushed directly to the master branch.

Deep changes that affect a lot of files should be pushed to a new branch first.

That is not a strict rule, just use the common sense and try not to break 
vimwiki master branch.

Original comment by habamax on 19 Mar 2013 at 4:06

GoogleCodeExporter commented 8 years ago
Ok. Thank you for your explanation. :)

Original comment by themacropodus@gmail.com on 19 Mar 2013 at 4:14

GoogleCodeExporter commented 8 years ago

Original comment by themacropodus@gmail.com on 21 Mar 2013 at 7:05