One9398 / vimwiki

Automatically exported from code.google.com/p/vimwiki
0 stars 1 forks source link

No-folding configuration ignored #415

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Starting with this basic configuration:

  filetype plugin on
  syntax on
  let g:vimwiki_list = [{ 'path': '~/vimwiki/', 'folding' : 0, 'ext': '.txt' }]
  let g:vimwiki_global_ext = 0
  let g:vimwiki_folding = 0

both the wiki and global 'folding = 0' options are ignored and folding is 
always enabled. Replacing the zero with an empty string yields the same result.

hg bisect points to this changeset:
 - 4e1a8b990979 "Issue 261: syntax folding is back"

I would expect folding to be disabled for wikis when specified in the 
configuration, even if folding is generally enabled in vim.

Original issue reported on code.google.com by dreadnaut on 5 Jun 2013 at 1:09

GoogleCodeExporter commented 8 years ago
See :h g:vimwiki_folding

There was a change in what values could be set by this option

In your case you should have
let g:vimwiki_folding = ''

There is also a line in changelog:
    * |g:vimwiki_folding| also accepts value 'list'; with 'expr' both sections
      and code blocks folded, g:vimwiki_fold_lists option was removed

Original comment by habamax on 5 Jun 2013 at 7:23

GoogleCodeExporter commented 8 years ago
As I wrote in my first post, changing the setting to an empty string makes no 
difference.

Also, I could not find any == '' checks in the code, so having 0 or an empty 
string does not make a difference.

> grep -r if.*vimwiki_folding *
plugin/vimwiki.vim:  if g:vimwiki_folding == 'expr'
plugin/vimwiki.vim:  elseif g:vimwiki_folding == 'list' || g:vimwiki_folding == 
'lists'
plugin/vimwiki.vim:  elseif g:vimwiki_folding == 'syntax'

Original comment by dreadnaut on 5 Jun 2013 at 8:05

GoogleCodeExporter commented 8 years ago
This is fixed in dev branch on github.

https://github.com/vimwiki/vimwiki/tree/dev

I do switch my vimwiki development towards github...

Original comment by habamax on 18 Jun 2013 at 2:49

GoogleCodeExporter commented 8 years ago
Thank you, I'll check out the code from there.

Original comment by dreadnaut on 21 Jun 2013 at 11:46