OneBusAway / onebusaway-gtfs-modules

A Java-based library for reading, writing, and transforming public transit data in the GTFS format, including database support.
Other
129 stars 106 forks source link

Avoid system locales with GTFS output formatting #161

Closed tvainika closed 2 years ago

tvainika commented 4 years ago

Summary:

Fix getSecondsAsString to return '-' (U+002D ASCII minus) instead of locale specific character such as '−' (U+2212 minus sign).

Expected behavior:

The method StopTimeFieldMappingFactory.getSecondsAsString should always return ASCII minus sign as negative sign, because the output string is used GTFS output files. Therefore system locale should not affect the method behavior or return value. This software is usually running in server environments without specific locale settings, so it might not come up often.

CLAassistant commented 4 years ago

CLA assistant check
All committers have signed the CLA.