search

OneCricketeer / apache-kafka-connect-docker

[KAFKA-9774] Un-official Docker Image for Apache Kafka Connect
https://issues.apache.org/jira/browse/KAFKA-9774
Apache License 2.0
34 stars 15 forks source link

Changing jib behaviour to have current timestamp rather than start of Unix epoch as image creation time. #7

Closed Sounie closed 2 years ago

Sounie commented 2 years ago

I've just tried building locally and found it confusing to see Docker indicating that the image was created 52 years ago.

So I did some digging and came across: https://github.com/GoogleContainerTools/jib/blob/master/docs/faq.md#why-is-my-image-created-48-years-ago

I have a preference for the metadata indicating the actual image creation time.

If someone really wants to reproduce the build then presumably they could just specify the image's timestamp in place of USE_CURRENT_TIMESTAMP.

OneCricketeer commented 2 years ago

While this doesn't really negatively affect the runtime image in any way, what is the use-case for viewing/having this value be updated to the build-time?

Sounie commented 2 years ago

When building locally or pulling down from Dockerhub, this is part of what I see if I run:

> docker image ls

REPOSITORY                                 TAG                    IMAGE ID       CREATED         SIZE
cricketeerone/apache-kafka-connect         3.2.0                  d5fa66afe65a   52 years ago    267MB
cricketeerone/apache-kafka-connect         latest                 d5fa66afe65a   52 years ago    267MB

So it's not something that shows up on the container registry, but just looks odd when interacting with it as an artifact that I want to try running.

If I am building it locally, it would be nice to be able to see at a glance that the latest image was built a few hours or minutes ago.

I don't have a really strong opinion on this, I just found it a bit confusing compared to other Docker builds that I have run (which probably also haven't involved jib).