OneDeadKey / kalamine

Keyboard Layout Maker
MIT License
106 stars 29 forks source link

Fedora/EPEL packages #189

Open fabi1cazenave opened 6 days ago

fabi1cazenave commented 6 days ago

Kalamine has official DEB packages (Debian and Ubuntu); RPM packages would be nice to see as well.

The first step would be to make a Fedora package: https://docs.fedoraproject.org/en-US/package-maintainers/Package_Review_Process/

Then an EPEL package, to make it available to RHEL-like plstforms: https://docs.fedoraproject.org/en-US/epel/epel-package-request/

@carlwgeorge, your help will be appreciated here! :-)

carlwgeorge commented 5 days ago

I've got an initial RPM spec file for this, but I've got a few questions based on the results of the rpmlint tool.

kalamine.noarch: E: zero-length /usr/lib/python3.13/site-packages/kalamine/generators/__init.py__

That error message is a bit obtuse, but it goes away if I rename the file to __init__.py. My guess is that rpmlint knows that a __init__.py file can be empty, but doesn't expect other files to be so it throws the error because of the non-standard name.

kalamine.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/kalamine/__init__.py 644 /usr/bin/env python3
kalamine.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/kalamine/cli.py 644 /usr/bin/env python3
kalamine.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/kalamine/cli_msklc.py 644 /usr/bin/env python3
kalamine.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/kalamine/cli_xkb.py 644 /usr/bin/env python3

From what I can tell the entrypoints to the program are the scripts created in /usr/bin, so it's unnecessary to use shebang lines in these files. Like the other error, I can resolve the error by adjusting the files during the RPM build.

Would these adjustments make sense to make here in this git repo? It's not strictly required because I can just keep the adjustments in the RPM spec file, but to me they seem practical enough for everyone.

carlwgeorge commented 5 days ago

For anyone interested in trying out the RPM package early on Fedora 40/41/Rawhide, you can get it from my copr for package reviews.

dnf copr enable carlwgeorge/reviews 
dnf install kalamine

The review is taking place in rhbz#2314587 for inclusion in the official Fedora repos.