search

OneDrive / onedrive-sdk-dotnet-msa-auth-adapter

Other
25 stars 22 forks source link

Update dependency on Microsoft.IdentityModel.Clients.ActiveDirectory <= 3.0 to latest version #40

Open oatsoda opened 7 years ago

oatsoda commented 7 years ago

Currently limited to <= 3.0 but the latest version is 3.13.8

adityanag commented 7 years ago

I have the same issue. Trying to use this with my UWP app that also uses the UWP ToolKit. 

Version conflict detected for Microsoft.IdentityModel.Clients.ActiveDirectory. 
 BookBoard (>= 1.0.0) -> Microsoft.Toolkit.Uwp.Services (>= 1.3.1) -> Microsoft.IdentityModel.Clients.ActiveDirectory (>= 3.13.7) 
 BookBoard (>= 1.0.0) -> Microsoft.OneDriveSDK.Authentication (>= 1.0.8) -> Microsoft.IdentityModel.Clients.ActiveDirectory (> 2.22.0 && < 3.0.0).
23W commented 7 years ago

I have similar issue. Why has dependency not been updated still?

oatsoda commented 7 years ago

I had a quick look to see if I could submit a pull request, but it looks like there are breaking changes (presumably this is why Microsoft.IdentityModel.Clients.ActiveDirectory moved to v3!).

The main one being that the AuthenticationResult no longer has properties called RefreshToken or IsMultipleResourceRefreshToken, which unfortunately looks like they have been wrapped. See https://github.com/OneDrive/onedrive-sdk-dotnet-msa-auth-adapter/blob/master/src/OneDrive.Sdk.Authentication.Common/Business/AuthenticationResultWrapper.cs#L89

martinlaukkanen commented 7 years ago

Please can the package at least be updated past 2.21.301221612 which is no longer available? 2.22 is the minimum available on nuget.

With 2.21 being referenced projects which cannot support assembly binding redirection cannot function! This include PowerShell modules where (any sane person) refuses to update system32 located .config files.