search

OneDrive / samples

Contains samples, scenarios, and guidance for integrating with OneDrive and SharePoint drives, drive items, and files.
MIT License
58 stars 59 forks source link

OneDrive and SharePoint File Picker v8 - ChannelSettings.Read.All #14

Closed figgsoftware closed 1 year ago

figgsoftware commented 2 years ago

Super excited about the new FilePicker v8! However I am wondering why the ChannelSettings.Read.All permission scope is needed if we already have Groups.ReadWrite.All? It will certainly hurt adoption if we need another admin consented scope to have it working.

Category

ghost commented 2 years ago

Thank you for your contribution to OneDrive API Docs. We will be triaging your incoming issue as soon as possible.

ntennant4 commented 2 years ago

Reviewing issue with OneDrive team and will follow-up with more details

patrick-rodgers commented 2 years ago

Hello @figgsoftware - sorry, unsure what you mean - can you expand on the scenario a bit? For the picker generally you only need file related permissions, but perhaps you are using it in a way we haven't tried.

figgsoftware commented 2 years ago

To list Channels in the picker you need to add the permission scope ChannelSettings.Read.All. We should be allowed to see channels in the picker if we have Groups.ReadWrite.All, so we don't need to add yet another admin consentet scope.

patrick-rodgers commented 2 years ago

Looking at the docs it seems that the group permissions are a hold over and most of the channels api is moving to support the channelsettings permissions. You can see an example here for list all channels where the group permissions don't appear. Here you can see where they note those permissions are for back-compat only and should be avoided. It reads to me that this is by design.

figgsoftware commented 2 years ago

When you are moving to new, more granular permissions for teams, it is not good to make scopes like ChannelSettings.Read.All admin consent required.

patrick-rodgers commented 1 year ago

Closing this issue as answered. If you have additional questions or we did not answer your question, please open a new issue, ref this issue, and provide any additional details available. Thank you!