search

OneKeyHQ / app-monorepo

Secure, open source and community driven crypto wallet runs on all platforms and trusted by millions.
https://onekey.so
Other
2.01k stars 384 forks source link

fix: Support rpcCall method for SCDO chain #6266

Closed originalix closed 5 days ago

originalix commented 6 days ago

Summary by CodeRabbit

codesandbox[bot] commented 6 days ago

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders
Open Preview

coderabbitai[bot] commented 6 days ago

Walkthrough

此次更改集中在 ProviderApiScdo 类的 ProviderApiScdo.ts 文件中。主要修改了 rpcCall 方法的实现，改为调用私有方法 _rpcCall(request)，该方法负责处理 RPC 调用的逻辑，包括错误处理和网络 ID 验证。同时，scdo_getBalance 和 scdo_estimateGas 方法也更新为调用新的 _rpcCall 方法，以简化实现。_signAndSendTransaction 方法保持基本结构不变，继续验证账户地址与交易的 "from" 字段是否匹配。

Changes

文件路径 更改摘要
packages/kit-bg/src/providers/ProviderApiScdo.ts 修改 rpcCall 方法，调用 _rpcCall(request) 处理请求。更新 scdo_getBalance 和 scdo_estimateGas 方法以调用 _rpcCall。_signAndSendTransaction 方法保留原结构，继续进行地址验证。

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant ProviderApiScdo
    participant AccountProfileService

    User->>ProviderApiScdo: rpcCall(request)
    ProviderApiScdo->>ProviderApiScdo: _rpcCall(request)
    ProviderApiScdo->>AccountProfileService: Proxy request
    AccountProfileService-->>ProviderApiScdo: Response
    ProviderApiScdo-->>User: Response
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` or `Summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.