OneSignal / OneSignal-Xamarin-SDK

OneSignal is a free push notification service for mobile apps. This plugin makes it easy to integrate your Xamarin app with OneSignal. https://onesignal.com
Other
105 stars 50 forks source link

Properly fill array of strings on iOS for DeleteTags #373

Closed brismithers closed 1 year ago

brismithers commented 1 year ago

Description

One Line Summary

Properly fill array of strings on iOS for DeleteTags

Details

Motivation

Fixes #372

Scope

This fix is limited to the DeleteTags method on iOS.

Testing

Manual testing

Using the example app, drive DeleteTags with various length number of tags.

Affected code checklist

Checklist

Overview

Testing

Final pass


This change is Reviewable

jennantilla commented 1 year ago

Interesting! So without count incrementing, the array of keys never finished building, leading to the malformed JSON?

brismithers commented 1 year ago

exactly @jennantilla, might also be a good check to add into the iOS/Android SDK to sanity check the input for null to be more explicit about the failure!