OneSignalDevelopers / ngosi

Share your slides with a QR code
https://ngosi.io
MIT License
9 stars 5 forks source link

changing structure of main page and adding new colors #83

Open devpato opened 2 years ago

devpato commented 2 years ago

⚠️ Click preview button above ⚠️

PR Template

  1. Apply relevant labels.
  2. Self-review code and PR.
  3. Request review from a team member.
  4. Wait for the code review.
  5. Take the bits that apply to your PR and delete the rest of template.

Fixes #.

Solution

###### Thing your're calling out

The thing being called out. Use a list when it makes sense.

Testing

Provide a test plan made up of a sorted list of discrete steps with expected outcomes the reviewer should expect. If the functionality that needs to be tested seems complicated to explain, including a short video in the resources section or offer to pair on the review.

1. Install the new depedency by running, `yarn`
2. Start the app, `yarn dev`
3. Submit a request to some endpoint
4. Observe stuff works!

Resources

Provide supporing content to help the reviewer review your PR. Content can include a mix of videos, gifs, images, and deep links (e.g., figma design resource, code snippets, messages, etc).

###### Short description of video

[video](#video/)

###### Short description of Gif

![gif](#gif/)

###### Short description of image

![image](#url/)

###### Short description of code snippet

Github perma link will be rendered as a code snippet

### Links

Bulleted list of deep links to things like figma, messages,

- [Short description of deep link](#deep-link/)
- [Designs in Figma](#figma-deep-link)
- [Something in Gdrive](#gdrive-link)
- [Get the idea?](#deep-link)

### References

Bulleted list of references used to implement the solution presented in this PR.

- [Short description of what's being linked to](#the-link/)
vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
ngosi ✅ Ready (Inspect) Visit Preview Jul 13, 2022 at 8:06PM (UTC)
Yohanan-Negash commented 2 years ago

@devpato Can you please work on the communication side of this PR? Reviewing this PR is hard since there is no explanation and no testing steps. You can use the template above ☝🏾 to demonstrate what you did 👍