search

OnetapInc / chromy

Chromy is a library for operating headless chrome. 🍺🍺🍺
MIT License
606 stars 41 forks source link

evaluate method can accept arguments #86

Closed TechQuery closed 6 years ago

TechQuery commented 6 years ago
TechQuery commented 6 years ago

@dotneet Is there any problem about this PR ?

dotneet commented 6 years ago

@TechQuery Sorry for my late response. This PR is great improvement! Thanks!

dotneet commented 6 years ago

v0.5.7 including this patch has been published now. thanks.

TechQuery commented 6 years ago

@dotneet You can host /docs folder by GitHub Pages to show JS API document online.

dotneet commented 6 years ago

@TechQuery Thanks! I've uploaded on GitHub Pages and wrote its link to readme. https://onetapinc.github.io/chromy/

TechQuery commented 6 years ago

@dotneet To complete all the JSDoc comment in source code can make ReadMe.md simpler, the Home page (API document) clearer and the Source code more semantic.

And I found a little bug:

I wrote zero console.log() in this PR, but when I passed arguments to the function to be evaluated, the code generated from Babel print the source code of this function by a console.log() statement...

Temporarily, I make console.log = function () { }; and use console.info() instead in production environment...