search

Open-Agriculture / AgIsoVirtualTerminal

A free, experimental ISO11783-6 Virtual Terminal (VT) server GUI based on AgIsoStack++
GNU General Public License v3.0
13 stars 0 forks source link

Müller MIDI 3.0 - Sprayer - button behavior #26

Open gunicsba opened 1 week ago

gunicsba commented 1 week ago

The following things I noticed in regards of buttons.

Reported hardware capabilities: 6 buttons was not working for me. Currently I'm running: 640 size 60x60 buttons 8 soft keys

This way it does load, and I'm able to modify a few parameters as well.

There's this button that has 2 purposes. It loads the next page when we do a single press, and it exits goes back when we do a long press. image

With 900 size and 10/12 softkeys it looks much better but still can't access all pages or traverse back from some menu

gunicsba commented 1 week ago

Did a quick video as well: https://youtu.be/4OK18cD5-Bk

And attaching the logs as well AgISOVirtualTerminalLogs_10_Oct_2024_12_18_31am.zip

gunicsba commented 1 week ago

Maybe the buttons should appear in 2 columns, like it's in the configurator? image image

ad3154 commented 1 week ago

The video definitely helps... it is interesting that it is complaining about invalid mask object IDs, as the ECU clearly thinks those are real/valid masks.

If I can figure out the issue with those masks, that should fix most things you are seeing. At this point I think I might want to write a little tool that just pulls all IOP data out of a CAN log so I can troubleshoot these issues faster...

Displaying soft keys in a second column probably does also make sense.

And I think it's possible the VT server isn't sending the still-held message for a button press? I will check that and see.

ad3154 commented 1 week ago

If you look in the app data folder for the VT, can you possibly send/attach the IOP files? By default they are located at %appdata%\Open-Agriculture\iso_data

gunicsba commented 1 week ago

Here's how it normally looks in a terminal: received_564628002647831 received_1375390433420433

received_897022741871390

gunicsba commented 1 week ago

Attaching the iop files as well: a00c80000c421b07.zip

ad3154 commented 1 week ago

I think I have addressed a portion of this (the errors when changing masks) in this commit of the stack https://github.com/Open-Agriculture/AgIsoStack-plus-plus/pull/400/commits/9c578cb34348d0d6a04acce22be82229c3b3b6fa

Will keep looking into the other parts

gunicsba commented 1 week ago

It's a LOT better! I've been able to visit about 99% of the menus, which is really great. Settings, calibration, etc all works.

I'm still unable to traverse back from some menus :/ In the configurator there are maximum 4 working screens. (I only configured the 1st and 2nd) It seems we're displaying the 2nd screen (i.e. 7 buttons)

Having the screen wider would be better as this way sometimes the buttons are outside of the visible area.

I made another quick video (Sadly I had to reset the ECU a few times to get back to the main menu.) https://www.youtube.com/watch?v=PH00Q9zbJWs

AgISOVirtualTerminalLogs_12_Oct_2024_12_20_05am.zip a00c80000c421b07 (2).zip

ad3154 commented 1 week ago

Added button "Still held" messages in this PR: https://github.com/Open-Agriculture/AgIsoVirtualTerminal/pull/29

gunicsba commented 3 days ago

@ad3154 the functionality does work as in I'm able to go back.

this menu and its submenus work well: 248

430

I'm able to move between main pages and pressing the button long I'm able to exit too.

559

However there are a few buttons that broke which used to work. image Can't enter the settings menu. (It exits within 100ms.) Can't start spraying. Can't move to 2nd page.

The circled one I'm not sure.

gunicsba commented 3 days ago

Also I tried to make the buttons in 2 columns (which was somewhat successful) However the 2nd column button can't be clicked so I need to play with that :D image However this layout resembles the pictures we've attached earlier from the terminal render.