Add mogpr timestep option

Open-EO / FuseTS

Time series Fusion toolbox integrated with openEO

https://open-eo.github.io/FuseTS/

Other

22 stars 4 forks source link

Add mogpr timestep option #104

Closed mlubej closed 1 year ago

mlubej commented 1 year ago

Changes:

added the option for a custom timestep (provided as '5D' or '1M' etc.
fixed a bug where the provided limited set of variables was not used to limit the data

Closes #96

(cc. @GriffinBabe I tried this out myself and it works, but it wouldn't hurt if you also give it a try)

GriffinBabe commented 1 year ago

In the mogpr function, there is an issue when leaving "prediction_period" as default (None): the "output_time_dimension" is not getting defined in that case. Other than that, the function seems to work fine, I ran mogpr with different prediction periods.

mlubej commented 1 year ago

In the mogpr function, there is an issue when leaving "prediction_period" as default (None): the "output_time_dimension" is not getting defined in that case. Other than that, the function seems to work fine, I ran mogpr with different prediction periods.

@GriffinBabe Is this based on the code review or did you encounter this during execution? It works for me in both cases.

If you ran into the issue, could you please provide a minimal example where I could test this?

mlubej commented 1 year ago

If you ran into the issue, could you please provide a minimal example where I could test this?

I see now I had unpushed commits...

GriffinBabe commented 1 year ago

Yes it works now, for me you can merge :)