search

Open-EO / FuseTS

Time series Fusion toolbox integrated with openEO
https://open-eo.github.io/FuseTS/
Other
22 stars 4 forks source link

Make the time steps size configurable in the mogpr method #96

Closed GriffinBabe closed 1 year ago

GriffinBabe commented 1 year ago

When using the fusets.mogpr method, the size of the temporal steps is enforced to 5. This constraint is not explained in the documentation: this gave me erroneous output data when I tried to use the method on data that was composited on 10 days.

Would it be possible to let the user specify the size of temporal steps, or maybe to try to deduce it from the input array coordinates?

Implementing a check that raises an error if temporal coordinates do not match the temporal step size would also help the user to use the function correctly.

@JanssenBrm

mlubej commented 1 year ago

@GriffinBabe I am implementing this functionality, but in the past I've only run the local version of the function. Do you perhaps still have an MVP code/notebook for running a small area with the open-eo implementation of mogpr, so I can test it?

JanssenBrm commented 1 year ago

@mlubej - Are you looking for something similar to this? https://github.com/Open-EO/FuseTS/blob/main/notebooks/OpenEO/FuseTS%20-%20MOGPR.ipynb

mlubej commented 1 year ago

Thanks @JanssenBrm , it turns out I was looking at the wrong function, so I was able to test things using the example from foss4g, but the above could also be used to test the change, however, I guess things first need to be merged for the updated function to become available in the namespace?

Additionally, I noticed the poor documentation of the MOGPR task, which was also exposed by @GriffinBabe and could be updated at some point.